yihua commented on code in PR #12826:
URL: https://github.com/apache/hudi/pull/12826#discussion_r1976002162
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestTable.java:
##########
@@ -1271,14 +1271,12 @@ private Option<HoodieCommitMetadata>
getCommitMeta(HoodieInstant hoodieInstant)
switch (hoodieInstant.getAction()) {
case REPLACE_COMMIT_ACTION:
case CLUSTERING_ACTION:
- HoodieReplaceCommitMetadata replaceCommitMetadata =
HoodieReplaceCommitMetadata
-
.fromBytes(metaClient.getActiveTimeline().getInstantDetails(hoodieInstant).get(),
HoodieReplaceCommitMetadata.class);
+ HoodieReplaceCommitMetadata replaceCommitMetadata =
metaClient.getActiveTimeline().loadInstantContent(hoodieInstant,
HoodieReplaceCommitMetadata.class);
return Option.of(replaceCommitMetadata);
case HoodieTimeline.DELTA_COMMIT_ACTION:
case HoodieTimeline.COMMIT_ACTION:
- HoodieCommitMetadata commitMetadata =
metaClient.getCommitMetadataSerDe().deserialize(
- hoodieInstant,
-
metaClient.getActiveTimeline().getInstantDetails(hoodieInstant).get(),
HoodieCommitMetadata.class);
+ HoodieCommitMetadata commitMetadata =
metaClient.getActiveTimeline().loadInstantContent(
+ hoodieInstant, HoodieCommitMetadata.class);
Review Comment:
nit: we can inline the logic now as it's much simpler
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/IncrementalRelationV1.scala:
##########
@@ -157,9 +157,9 @@ class IncrementalRelationV1(val sqlContext: SQLContext,
// create Replaced file group
val replacedTimeline =
commitsTimelineToReturn.getCompletedReplaceTimeline
+ val layout =
TimelineLayout.fromVersion(commitTimeline.getTimelineLayoutVersion)
Review Comment:
nit: remove unused variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
