yihua commented on code in PR #12826:
URL: https://github.com/apache/hudi/pull/12826#discussion_r1976089670
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/cdc/HoodieCDCTestBase.scala:
##########
@@ -110,10 +108,8 @@ abstract class HoodieCDCTestBase extends
HoodieSparkClientTestBase {
* extract a list of cdc log file.
*/
protected def getCDCLogFile(instant: HoodieInstant): List[String] = {
- val commitMetadata =
metaClient.getTimelineLayout.getCommitMetadataSerDe.deserialize(instant,
- metaClient.reloadActiveTimeline().getInstantDetails(instant).get(),
- classOf[HoodieCommitMetadata]
- )
+ val activeTimeline = metaClient.reloadActiveTimeline()
Review Comment:
similar here
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/cdc/HoodieCDCTestBase.scala:
##########
@@ -94,10 +94,8 @@ abstract class HoodieCDCTestBase extends
HoodieSparkClientTestBase {
* whether this instant will create a cdc log file.
*/
protected def hasCDCLogFile(instant: HoodieInstant): Boolean = {
- val commitMetadata =
metaClient.getTimelineLayout.getCommitMetadataSerDe.deserialize(instant,
- metaClient.reloadActiveTimeline().getInstantDetails(instant).get(),
- classOf[HoodieCommitMetadata]
- )
+ val timeline = metaClient.reloadActiveTimeline
Review Comment:
nit: inline the variable
##########
packaging/bundle-validation/service/read.scala:
##########
@@ -22,7 +22,5 @@ spark.read.format("hudi").
option("hoodie.table.name", tableName).
option("hoodie.database.name", "default").
option("hoodie.metadata.enable", "false").
- option("hoodie.metaserver.enabled", "true").
Review Comment:
HUDI-9069 to track Metaserver issue on master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
