yihua commented on code in PR #12826:
URL: https://github.com/apache/hudi/pull/12826#discussion_r1976103348
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/CompactionCommand.java:
##########
@@ -181,7 +181,7 @@ public String compactionShowArchived(
try {
archivedTimeline.loadCompactionDetailsInMemory(compactionInstantTime);
HoodieCompactionPlan compactionPlan =
-
TimelineMetadataUtils.deserializeCompactionPlan(archivedTimeline.getInstantDetails(instant).get());
+
TimelineMetadataUtils.deserializeCompactionPlan(archivedTimeline.getInstantContentStream(instant));
Review Comment:
As discussed offline, the general guideline is
(1) keep `readInstantContent(instant, clazz)` which should only be called by
the wrapper methods in `HoodieTimeline`;
(2) for each specific metadata object like `CleanPlan`, provide
`readCleanPlan(instant)` API for the callers outside `HoodieTimeline` so it's
straightforward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
