yihua commented on code in PR #12826:
URL: https://github.com/apache/hudi/pull/12826#discussion_r1976118973
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/utils/TestMetadataConversionUtils.java:
##########
@@ -194,8 +197,8 @@ public void testArchivedClean() throws Exception {
HoodieLSMTimelineInstant archived =
MetadataConversionUtils.createLSMTimelineInstant(getActiveInstant(newCommitTime),
metaClient);
assertEquals(newCommitTime, archived.getInstantTime());
assertEquals(HoodieTimeline.CLEAN_ACTION, archived.getAction());
- assertDoesNotThrow(() -> CleanerUtils.getCleanerMetadata(metaClient,
archived.getMetadata().array()));
- assertDoesNotThrow(() ->
TimelineMetadataUtils.deserializeCleanerPlan(archived.getPlan().array()));
+ assertDoesNotThrow(() -> CleanerUtils.getCleanerMetadata(metaClient, new
ByteArrayInputStream(archived.getMetadata().array())));
+ assertDoesNotThrow(() -> deserializeAvroMetadata(new
ByteArrayInputStream(archived.getPlan().array()), HoodieCleanerPlan.class));
Review Comment:
Makes sense. Then let's keep it for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
