yihua commented on code in PR #12900:
URL: https://github.com/apache/hudi/pull/12900#discussion_r1978411566
##########
hudi-platform-service/hudi-metaserver/hudi-metaserver-client/src/main/java/org/apache/hudi/common/table/timeline/HoodieMetaserverBasedTimeline.java:
##########
@@ -56,23 +60,26 @@ protected void deleteInstantFile(HoodieInstant instant) {
}
@Override
- protected void transitionStateToComplete(boolean shouldLock, HoodieInstant
fromInstant, HoodieInstant toInstant, Option<byte[]> data) {
+ protected <T> void transitionStateToComplete(boolean shouldLock,
HoodieInstant fromInstant, HoodieInstant toInstant, Option<T> metadata) {
ValidationUtils.checkArgument(fromInstant.requestedTime().equals(toInstant.requestedTime()));
- metaserverClient.transitionInstantState(databaseName, tableName,
fromInstant, toInstant, data);
+ metaserverClient.transitionInstantState(databaseName, tableName,
fromInstant, toInstant,
+ metadata.map(m -> convertMetadataToBytArray(m, metadataSerDeV2)));
Review Comment:
```suggestion
metadata.map(m -> convertMetadataToByteArray(m, metadataSerDeV2)));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
