yihua commented on code in PR #12900:
URL: https://github.com/apache/hudi/pull/12900#discussion_r1978370376
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v2/CommitMetadataSerDeV2.java:
##########
@@ -93,23 +91,10 @@ public <T> T deserialize(HoodieInstant instant, InputStream
inputStream, Boolean
}
@Override
- public Option<byte[]>
serialize(org.apache.hudi.common.model.HoodieCommitMetadata commitMetadata)
throws IOException {
- if (commitMetadata instanceof
org.apache.hudi.common.model.HoodieReplaceCommitMetadata) {
- return
serializeAvroMetadata(MetadataConversionUtils.convertCommitMetadata(commitMetadata),
HoodieReplaceCommitMetadata.class);
+ public <T> Option<HoodieInstantWriter> getInstantWriter(T metadata) {
+ if (metadata instanceof org.apache.hudi.common.model.HoodieCommitMetadata)
{
+ return
TimelineMetadataUtils.getInstantWriter(Option.of(MetadataConversionUtils.convertCommitMetadataToAvro((HoodieCommitMetadata)
metadata)));
Review Comment:
I see `TimelineMetadataUtils.getInstantWriter` is only used in
`CommitMetadatSerDe` classes. Should the actually logic be moved here so we
don't maintain the util method outside?
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v2/CommitMetadataSerDeV2.java:
##########
@@ -93,23 +91,10 @@ public <T> T deserialize(HoodieInstant instant, InputStream
inputStream, Boolean
}
@Override
- public Option<byte[]>
serialize(org.apache.hudi.common.model.HoodieCommitMetadata commitMetadata)
throws IOException {
- if (commitMetadata instanceof
org.apache.hudi.common.model.HoodieReplaceCommitMetadata) {
- return
serializeAvroMetadata(MetadataConversionUtils.convertCommitMetadata(commitMetadata),
HoodieReplaceCommitMetadata.class);
+ public <T> Option<HoodieInstantWriter> getInstantWriter(T metadata) {
+ if (metadata instanceof org.apache.hudi.common.model.HoodieCommitMetadata)
{
Review Comment:
Does this handle `HoodieReplaceCommitMetadata`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
