yihua commented on code in PR #12900:
URL: https://github.com/apache/hudi/pull/12900#discussion_r1978404070
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/table/view/TestHoodieTableFileSystemView.java:
##########
@@ -1895,18 +1889,18 @@ public void
testPendingCompactionWithDuplicateFileIdsAcrossPartitions(boolean pr
assertTrue(fileIdsInCompaction.contains(fileId));
}
- private void saveAsComplete(HoodieActiveTimeline timeline, HoodieInstant
inflight, Option<byte[]> data) {
+ private void saveAsComplete(HoodieActiveTimeline timeline, HoodieInstant
inflight, HoodieCommitMetadata metadata) {
if (inflight.getAction().equals(HoodieTimeline.COMPACTION_ACTION)) {
- timeline.transitionCompactionInflightToComplete(true, inflight, data);
+ timeline.transitionCompactionInflightToComplete(true, inflight,
metadata);
} else {
HoodieInstant requested =
INSTANT_GENERATOR.createNewInstant(State.REQUESTED, inflight.getAction(),
inflight.requestedTime());
timeline.createNewInstant(requested);
timeline.transitionRequestedToInflight(requested, Option.empty());
- timeline.saveAsComplete(inflight, data);
+ timeline.saveAsComplete(inflight, Option.of(metadata));
}
}
- private void saveAsCompleteCluster(HoodieActiveTimeline timeline,
HoodieInstant inflight, Option<byte[]> data) {
+ private <T> void saveAsCompleteCluster(HoodieActiveTimeline timeline,
HoodieInstant inflight, HoodieCommitMetadata metadata) {
Review Comment:
```suggestion
private void saveAsCompleteCluster(HoodieActiveTimeline timeline,
HoodieInstant inflight, HoodieCommitMetadata metadata) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
