yihua commented on code in PR #12900:
URL: https://github.com/apache/hudi/pull/12900#discussion_r1978379964
##########
hudi-common/src/test/java/org/apache/hudi/common/testutils/FileCreateUtils.java:
##########
@@ -185,29 +173,28 @@ public static void
createInflightReplaceCommit(HoodieTableMetaClient metaClient,
public static void createReplaceCommit(HoodieTableMetaClient metaClient,
CommitMetadataSerDe commitMetadataSerDe,
String instantTime,
HoodieReplaceCommitMetadata metadata) throws IOException {
createMetaFile(metaClient, instantTime,
HoodieTimeline.REPLACE_COMMIT_EXTENSION,
- serializeCommitMetadata(commitMetadataSerDe, metadata).get());
+ Option.of(metadata));
}
public static void createReplaceCommit(HoodieTableMetaClient metaClient,
CommitMetadataSerDe commitMetadataSerDe,
String instantTime, String
completionTime, HoodieReplaceCommitMetadata metadata) throws IOException {
createMetaFileInTimelinePath(
metaClient, instantTime, () -> completionTime,
HoodieTimeline.REPLACE_COMMIT_EXTENSION,
- serializeCommitMetadata(commitMetadataSerDe, metadata).get());
+ metaClient.getCommitMetadataSerDe().getInstantWriter(metadata));
}
public static void createRequestedClusterCommit(HoodieTableMetaClient
metaClient, String instantTime,
HoodieRequestedReplaceMetadata requestedReplaceMetadata)
throws IOException {
createMetaFile(metaClient, instantTime,
HoodieTimeline.REQUESTED_CLUSTERING_COMMIT_EXTENSION,
- serializeRequestedReplaceMetadata(requestedReplaceMetadata).get());
+ Option.of(requestedReplaceMetadata));
}
- public static void createInflightClusterCommit(HoodieTableMetaClient
metaClient, CommitMetadataSerDe commitMetadataSerDe,
- String instantTime,
Option<HoodieCommitMetadata> inflightReplaceMetadata)
+ public static <T> void createInflightClusterCommit(HoodieTableMetaClient
metaClient, CommitMetadataSerDe commitMetadataSerDe,
+ String instantTime,
Option<T> inflightReplaceMetadata)
Review Comment:
nit: can still use `HoodieCommitMetadata`?
##########
hudi-common/src/test/java/org/apache/hudi/common/model/TestHoodieCommitMetadata.java:
##########
@@ -180,7 +181,7 @@ public void testCommitMetadataSerde() throws Exception {
// Case: Reading 0.x written commit metadata
HoodieInstant legacyInstant =
INSTANT_GENERATOR.createNewInstant(HoodieInstant.State.COMPLETED, "commit",
"1", "1", true);
CommitMetadataSerDe v1SerDe = new CommitMetadataSerDeV1();
- byte[] v1Bytes = v1SerDe.serialize(commitMetadata1).get();
+ byte[] v1Bytes = convertMetadataToBytArray(commitMetadata1, v1SerDe);
Review Comment:
```suggestion
byte[] v1Bytes = convertMetadataToByteArray(commitMetadata1, v1SerDe);
```
##########
hudi-common/src/test/java/org/apache/hudi/common/table/timeline/versioning/v2/TestCommitMetadataSerDeV2.java:
##########
@@ -65,9 +64,8 @@ public void testLegacyInstant() throws Exception {
// Serialize and deserialize
- Option<byte[]> serialized = serDeV1.serialize(metadata);
- assertTrue(serialized.isPresent());
- HoodieCommitMetadata deserialized = getSerDe().deserialize(instant, new
ByteArrayInputStream(serialized.get()), () -> false,
HoodieCommitMetadata.class);
+ byte[] serialized = convertMetadataToBytArray(metadata, serDeV1);
Review Comment:
```suggestion
byte[] serialized = convertMetadataToByteArray(metadata, serDeV1);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
