yihua commented on code in PR #13261:
URL: https://github.com/apache/hudi/pull/13261#discussion_r2094044085
##########
hudi-spark-datasource/hudi-spark-common/src/main/java/org/apache/hudi/commit/DatasetBucketRescaleCommitActionExecutor.java:
##########
@@ -64,14 +64,15 @@ protected BulkInsertPartitioner<Dataset<Row>>
getPartitioner(boolean populateMet
/**
* create new hashing_config during afterExecute and before commit finished.
- * @param result
*/
@Override
protected void preExecute() {
super.preExecute();
+ hashingConfig = new PartitionBucketIndexHashingConfig(expression,
Review Comment:
Could we make this `hashingConfig` a local variable so the instant time is
only used within `preExecute`? `#getPartitioner` which calls `new
BucketIndexBulkInsertPartitionerWithRows(writeConfig.getBucketIndexHashFieldWithDefault(),
hashingConfig)` does not use the instant time so `expression`, `bucketNumber`,
and `rule` can be passed to `BucketIndexBulkInsertPartitionerWithRows`
constructor instead to avoid leaking the instant time to the partitioner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
