the-other-tim-brown commented on code in PR #13261:
URL: https://github.com/apache/hudi/pull/13261#discussion_r2094127504
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/StreamSync.java:
##########
@@ -466,14 +466,14 @@ public Pair<Option<String>, JavaRDD<WriteStatus>>
syncOnce() throws IOException
try {
// Refresh Timeline
HoodieTableMetaClient metaClient =
initializeMetaClientAndRefreshTimeline();
- String instantTime = metaClient.createNewInstantTime();
- Pair<InputBatch, Boolean> inputBatchAndUseRowWriter =
readFromSource(instantTime, metaClient);
+ Pair<InputBatch, Boolean> inputBatchAndUseRowWriter =
readFromSource(metaClient);
if (inputBatchAndUseRowWriter != null) {
InputBatch inputBatch = inputBatchAndUseRowWriter.getLeft();
boolean useRowWriter = inputBatchAndUseRowWriter.getRight();
initializeWriteClientAndRetryTableServices(inputBatch, metaClient);
+ String instantTime = startCommit(metaClient, !autoGenerateRecordKeys);
Review Comment:
Makes sense, updating now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
