the-other-tim-brown commented on code in PR #13261:
URL: https://github.com/apache/hudi/pull/13261#discussion_r2094129373
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -944,10 +953,23 @@ public void startCommitWithTime(String instantTime) {
}
/**
- * Completes a new commit time for a write operation
(insert/update/delete/insert_overwrite/insert_overwrite_table) with specified
action.
+ * Provides a new commit at the specified time with the provided action type.
+ * This is only for testing purposes to setup particular sequences of
commits.
+ * @param instantTime the commit start time
+ * @param actionType the type of commit
+ */
+ @VisibleForTesting
+ void startCommitWithTime(String instantTime, String actionType) {
+ HoodieTableMetaClient metaClient = createMetaClient(true);
+ startCommitWithTime(instantTime, actionType, metaClient);
+ }
+
+ /**
+ * Starts a new commit time for a write operation against the metadata table
with the provided instant and action type.
*/
- public void startCommitWithTime(String instantTime, String actionType) {
+ public void startCommitForMetadataTable(String instantTime, String
actionType) {
HoodieTableMetaClient metaClient = createMetaClient(true);
+ ValidationUtils.checkArgument(metaClient.isMetadataTable(), "Attempting to
create an instant with a predetermined time on a non-metadata table.");
Review Comment:
I'm passing in the meta client now for the mdt so this looks a bit different
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
