the-other-tim-brown commented on code in PR #13261:
URL: https://github.com/apache/hudi/pull/13261#discussion_r2094128632
##########
hudi-spark-datasource/hudi-spark-common/src/main/java/org/apache/hudi/commit/DatasetBucketRescaleCommitActionExecutor.java:
##########
@@ -64,14 +64,15 @@ protected BulkInsertPartitioner<Dataset<Row>>
getPartitioner(boolean populateMet
/**
* create new hashing_config during afterExecute and before commit finished.
- * @param result
*/
@Override
protected void preExecute() {
super.preExecute();
+ hashingConfig = new PartitionBucketIndexHashingConfig(expression,
Review Comment:
I am not understanding this suggestion. The hashing config requires the
instant time currently and the partitioner requires the hashing config. The
config must be persisted in the preExecute according to the existing code so I
don't see another way to set this up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
