the-other-tim-brown commented on code in PR #13399:
URL: https://github.com/apache/hudi/pull/13399#discussion_r2136086582
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/marker/DirectWriteMarkers.java:
##########
@@ -189,26 +188,17 @@ public Option<StoragePath>
createWithEarlyConflictDetection(String partitionPath
private Option<StoragePath> create(StoragePath markerPath, boolean
checkIfExists) {
HoodieTimer timer = HoodieTimer.start();
- StoragePath dirPath = markerPath.getParent();
- try {
- if (!storage.exists(dirPath)) {
- storage.createDirectory(dirPath); // create a new partition as needed.
Review Comment:
The API states that it will create the folders in the path if they do not
exist already so this call is redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
