the-other-tim-brown commented on code in PR #13399:
URL: https://github.com/apache/hudi/pull/13399#discussion_r2136092150
##########
hudi-common/src/main/java/org/apache/hudi/timeline/TimelineServiceClient.java:
##########
@@ -61,7 +61,7 @@ protected Response executeRequest(Request request) throws
IOException {
String url = builder.toString();
LOG.debug("Sending request : ({})", url);
org.apache.http.client.fluent.Response response = get(request.getMethod(),
url, timeoutMs);
- return new Response(response.returnContent().asString());
+ return new Response(response.returnContent().asStream());
Review Comment:
This is the only place we are handling responses that I could find. Our use
of Jackson is not limited to the timeline service though. There are some other
places in the code that still go through Strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
