the-other-tim-brown commented on code in PR #13399:
URL: https://github.com/apache/hudi/pull/13399#discussion_r2136093388
##########
hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/handlers/marker/MarkerDirState.java:
##########
@@ -94,12 +92,11 @@ public class MarkerDirState implements Serializable {
public MarkerDirState(String markerDirPath, int markerBatchNumThreads,
Option<TimelineServerBasedDetectionStrategy>
conflictDetectionStrategy,
- HoodieStorage storage, Registry metricsRegistry,
- HoodieEngineContext hoodieEngineContext, int
parallelism) {
- this.markerDirPath = markerDirPath;
+ HoodieStorage storage, Registry metricsRegistry, int
parallelism) {
+ this.markerDirPath = new StoragePath(markerDirPath);
this.storage = storage;
this.metricsRegistry = metricsRegistry;
- this.hoodieEngineContext = hoodieEngineContext;
+ this.hoodieEngineContext = new HoodieLocalEngineContext(storage.getConf());
Review Comment:
Is this fine or should it be passed in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
