the-other-tim-brown commented on code in PR #13399:
URL: https://github.com/apache/hudi/pull/13399#discussion_r2136095402


##########
hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/handlers/MarkerHandler.java:
##########
@@ -274,7 +269,7 @@ private CompletableFuture<String> 
finishCreateMarkerFuture(Context context, Stri
     MarkerCreationFuture future = new MarkerCreationFuture(context, markerDir, 
markerName);
     try {
       future.complete(jsonifyResult(
-          future.getContext(), future.isSuccessful(), metricsRegistry, new 
ObjectMapper(), LOG));
+          future.getContext(), future.isSuccessful(), metricsRegistry, LOG));

Review Comment:
   It is only used for debug logs on the time taken to "jsonify" the string. I 
am not sure why it needs to be passed in in the first place.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to