danny0405 commented on code in PR #13445:
URL: https://github.com/apache/hudi/pull/13445#discussion_r2151125988
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/BaseSparkInternalRowReaderContext.java:
##########
@@ -171,9 +183,6 @@ public Comparable convertValueToEngineType(Comparable
value) {
@Override
public InternalRow getDeleteRow(InternalRow record, String recordKey) {
- if (record != null) {
Review Comment:
Are you saying the records written to log data block from spark is always
not a delete? This is not true as when the customized delete marker is there.
Can we return `HoodieInternalRow` with `isDelete` set up in there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
