the-other-tim-brown commented on code in PR #13445:
URL: https://github.com/apache/hudi/pull/13445#discussion_r2151122789
##########
hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieReaderContext.java:
##########
@@ -378,6 +378,16 @@ public Comparable getOrderingValue(T record,
*/
public abstract HoodieRecord<T> constructHoodieRecord(BufferedRecord<T>
bufferedRecord);
+ /**
+ * Constructs a new {@link HoodieRecord} based on the given record and
schema.
+ *
+ * @param record The engine-specific row.
+ * @param schema The Avro schema of the record.
+ * @param orderingFieldName The name of the ordering field, if any.
+ * @return A new instance of {@link HoodieRecord}.
+ */
+ public abstract HoodieRecord<T> constructHoodieRecord(T record, Schema
schema, Option<String> orderingFieldName);
Review Comment:
Without this we will need a way to determine if the record is a delete
record even when the data may not be set. If there is a way to do this across
all engine types (not just Flink) then we can use that. Without this you will
get runtime errors when trying to read as a HoodieRecord.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
