the-other-tim-brown commented on code in PR #13445:
URL: https://github.com/apache/hudi/pull/13445#discussion_r2151162216
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/BaseSparkInternalRowReaderContext.java:
##########
@@ -171,9 +183,6 @@ public Comparable convertValueToEngineType(Comparable
value) {
@Override
public InternalRow getDeleteRow(InternalRow record, String recordKey) {
- if (record != null) {
Review Comment:
When we read the data from the log block, it is not going to have an
operation type set. We can determine it is a delete by inspecting the record
for `_hoodie_is_delete` or by a field used to mark deletes or the merger will
output an empty option to signal a delete in the case of custom mergers and
payloads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
