the-other-tim-brown commented on code in PR #13445:
URL: https://github.com/apache/hudi/pull/13445#discussion_r2151183064
##########
hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieReaderContext.java:
##########
@@ -378,6 +378,16 @@ public Comparable getOrderingValue(T record,
*/
public abstract HoodieRecord<T> constructHoodieRecord(BufferedRecord<T>
bufferedRecord);
+ /**
+ * Constructs a new {@link HoodieRecord} based on the given record and
schema.
+ *
+ * @param record The engine-specific row.
+ * @param schema The Avro schema of the record.
+ * @param orderingFieldName The name of the ordering field, if any.
+ * @return A new instance of {@link HoodieRecord}.
+ */
+ public abstract HoodieRecord<T> constructHoodieRecord(T record, Schema
schema, Option<String> orderingFieldName);
Review Comment:
only other option I see is to make the HoodieReaderContext have a method for
`isDeleteOperation(T record)` and then we can use that to set the value for
`isDelete` in this
[line](https://github.com/apache/hudi/blob/master/hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java#L388),
but that is just a roundabout way to get back to the same result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
