lokeshj1703 commented on code in PR #13718:
URL: https://github.com/apache/hudi/pull/13718#discussion_r2283026197
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -171,8 +171,9 @@ public class HoodieWriteConfig extends HoodieConfig {
+ "Refer to org.apache.spark.storage.StorageLevel for different
values");
public static final ConfigProperty<String> PRECOMBINE_FIELD_NAME =
ConfigProperty
- .key("hoodie.datasource.write.precombine.field")
+ .key("hoodie.datasource.write.precombine.fields")
Review Comment:
Addressed
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java:
##########
@@ -158,8 +158,9 @@ public class HoodieTableConfig extends HoodieConfig {
// TODO: is this this called precombine in 1.0. ..
public static final ConfigProperty<String> PRECOMBINE_FIELDS = ConfigProperty
- .key("hoodie.table.precombine.field")
+ .key("hoodie.table.precombine.fields")
Review Comment:
Addressed
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -110,14 +110,15 @@ private FlinkOptions() {
.withDescription("Type of table to write. COPY_ON_WRITE (or)
MERGE_ON_READ");
public static final String NO_PRE_COMBINE = "no_precombine";
- public static final ConfigOption<String> PRECOMBINE_FIELD = ConfigOptions
- .key("precombine.field")
+ public static final ConfigOption<String> PRECOMBINE_FIELDS = ConfigOptions
+ .key("precombine.fields")
Review Comment:
Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
