lokeshj1703 commented on code in PR #13718:
URL: https://github.com/apache/hudi/pull/13718#discussion_r2283028694
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/SevenToEightUpgradeHandler.java:
##########
@@ -168,7 +168,7 @@ static void upgradePartitionFields(HoodieWriteConfig
config, HoodieTableConfig t
static void upgradeMergeMode(HoodieTableConfig tableConfig,
Map<ConfigProperty, String> tablePropsToAdd) {
String payloadClass = tableConfig.getPayloadClass();
- String preCombineFields =
tableConfig.getPreCombineFieldsStr().orElse(null);
+ String preCombineFields = tableConfig.getOrderingFieldsStr().orElse(null);
Review Comment:
Addressed
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -170,9 +170,11 @@ public class HoodieWriteConfig extends HoodieConfig {
.withDocumentation("Determine what level of persistence is used to cache
write RDDs. "
+ "Refer to org.apache.spark.storage.StorageLevel for different
values");
+ @Deprecated
public static final ConfigProperty<String> PRECOMBINE_FIELD_NAME =
ConfigProperty
.key("hoodie.datasource.write.precombine.field")
.noDefaultValue()
+ .withAlternatives("hoodie.datasource.write.precombine.field")
Review Comment:
Addressed
##########
hudi-examples/hudi-examples-spark/src/test/python/HoodiePySparkQuickstart.py:
##########
@@ -35,7 +35,7 @@ def __init__(self, spark: sql.SparkSession, tableName: str,
basePath: str):
'hoodie.datasource.write.recordkey.field': 'uuid',
'hoodie.datasource.write.partitionpath.field': 'partitionpath',
'hoodie.datasource.write.operation': 'upsert',
- 'hoodie.datasource.write.precombine.field': 'ts',
+ 'hoodie.datasource.write.precombine.fields': 'ts',
Review Comment:
Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
