lokeshj1703 commented on code in PR #13718:
URL: https://github.com/apache/hudi/pull/13718#discussion_r2283030295
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -110,14 +110,15 @@ private FlinkOptions() {
.withDescription("Type of table to write. COPY_ON_WRITE (or)
MERGE_ON_READ");
public static final String NO_PRE_COMBINE = "no_precombine";
- public static final ConfigOption<String> PRECOMBINE_FIELD = ConfigOptions
- .key("precombine.field")
+ public static final ConfigOption<String> ORDERING_FIELDS = ConfigOptions
+ .key("ordering.fields")
.stringType()
.defaultValue("ts")
- .withFallbackKeys("write.precombine.field",
HoodieWriteConfig.PRECOMBINE_FIELD_NAME.key())
+ .withFallbackKeys("precombine.field", "write.precombine.field",
HoodieWriteConfig.PRECOMBINE_FIELD_NAME.key())
.withDescription("Comma separated list of fields used in preCombining
before actual write. When two records have the same\n"
+ "key value, we will pick the one with the largest value for the
precombine field,\n"
- + "determined by Object.compareTo(..). For multiple fields if first
key comparison is same, second key comparison is made and so on");
+ + "determined by Object.compareTo(..). For multiple fields if first
key comparison is same, second key comparison is made and so on.\n"
+ + "Config precombine.field is now deprecated, please use
precombine.fields instead.");
Review Comment:
Addressed
##########
hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/SparkDataSourceContinuousIngestTool.java:
##########
@@ -61,7 +61,7 @@
* hoodie.datasource.write.recordkey.field=VendorID
* hoodie.datasource.write.partitionpath.field=date_col
* hoodie.datasource.write.operation=upsert
- * hoodie.datasource.write.precombine.field=tpep_pickup_datetime
+ * hoodie.datasource.write.precombine.fields=tpep_pickup_datetime
Review Comment:
Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
