lokeshj1703 commented on code in PR #13718:
URL: https://github.com/apache/hudi/pull/13718#discussion_r2283030866
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala:
##########
@@ -1073,6 +1071,7 @@ object DataSourceOptionsHelper {
/**
* Returns optional list of precombine fields from the provided parameteres.
*/
+ @deprecated("Use preCombine key in table config", "1.1.0")
Review Comment:
Addressed
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieHadoopFsRelationFactory.scala:
##########
@@ -186,7 +186,7 @@ abstract class HoodieBaseHadoopFsRelationFactory(val
sqlContext: SQLContext,
}
protected lazy val preCombineFields: List[String] = {
- val tablePrecombineFields = tableConfig.getPreCombineFields
+ val tablePrecombineFields = tableConfig.getOrderingFields
Review Comment:
Addressed
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/CreateHoodieTableCommand.scala:
##########
@@ -125,7 +125,7 @@ object CreateHoodieTableCommand {
val originTableConfig =
hoodieCatalogTable.tableConfig.getProps.asScala.toMap
val tableOptions = hoodieCatalogTable.catalogProperties
- checkTableConfigEqual(originTableConfig, tableOptions,
HoodieTableConfig.PRECOMBINE_FIELDS.key)
+ checkTableConfigEqual(originTableConfig, tableOptions,
HoodieTableConfig.ORDERING_FIELDS.key)
Review Comment:
Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
