yihua commented on code in PR #17524:
URL: https://github.com/apache/hudi/pull/17524#discussion_r2599836636
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/TableWriteStats.java:
##########
@@ -20,12 +20,15 @@
import org.apache.hudi.common.model.HoodieWriteStat;
+import lombok.Getter;
+
import java.util.Collections;
import java.util.List;
/**
* Class to hold list of {@link HoodieWriteStat} for data table and metadata
table.
*/
+@Getter
Review Comment:
Use `@Value` for immutable classes?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/WriteStatus.java:
##########
@@ -49,32 +50,48 @@
* Status of a write operation.
*/
@PublicAPIClass(maturity = ApiMaturityLevel.STABLE)
+@Slf4j
public class WriteStatus implements Serializable {
-
- private static final Logger LOG = LoggerFactory.getLogger(WriteStatus.class);
private static final long serialVersionUID = 1L;
private static final long RANDOM_SEED = 9038412832L;
+ @Getter
Review Comment:
Should we consider making this a `@Data` class too as adding multiple
annotations does not help the readability?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
