yihua commented on code in PR #17524:
URL: https://github.com/apache/hudi/pull/17524#discussion_r2600460672
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bloom/KeyRangeNode.java:
##########
@@ -26,16 +29,23 @@
* Represents a node in the {@link KeyRangeLookupTree}. Holds information
pertaining to a single index file, viz file
* name, min record key and max record key.
*/
+@Getter
class KeyRangeNode implements Comparable<KeyRangeNode>, Serializable {
private final List<String> fileNameList = new ArrayList<>();
private final String minRecordKey;
private final String maxRecordKey;
+ @Setter
private String rightSubTreeMax = null;
+ @Setter
private String leftSubTreeMax = null;
+ @Setter
private String rightSubTreeMin = null;
+ @Setter
private String leftSubTreeMin = null;
+ @Setter
private KeyRangeNode left = null;
+ @Setter
Review Comment:
Annotate the class with `@Setter` to avoid multiple annotations?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bloom/BloomIndexFileInfo.java:
##########
@@ -26,10 +28,13 @@
*/
public class BloomIndexFileInfo implements Serializable {
Review Comment:
Similarly, could we use `@Value` on this class?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/heartbeat/HoodieHeartbeatClient.java:
##########
@@ -72,21 +73,21 @@ public HoodieHeartbeatClient(HoodieStorage storage, String
basePath, Long heartb
static class Heartbeat {
Review Comment:
Make this a `@Data` class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
