voonhous commented on code in PR #17524:
URL: https://github.com/apache/hudi/pull/17524#discussion_r2600994953
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bloom/KeyRangeNode.java:
##########
@@ -26,16 +29,23 @@
* Represents a node in the {@link KeyRangeLookupTree}. Holds information
pertaining to a single index file, viz file
* name, min record key and max record key.
*/
+@Getter
class KeyRangeNode implements Comparable<KeyRangeNode>, Serializable {
private final List<String> fileNameList = new ArrayList<>();
private final String minRecordKey;
private final String maxRecordKey;
+ @Setter
private String rightSubTreeMax = null;
+ @Setter
private String leftSubTreeMax = null;
+ @Setter
private String rightSubTreeMin = null;
+ @Setter
private String leftSubTreeMin = null;
+ @Setter
private KeyRangeNode left = null;
+ @Setter
Review Comment:
Oh, cool, TIL that `@Setter ignores private finals` too.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bloom/KeyRangeNode.java:
##########
@@ -26,16 +29,23 @@
* Represents a node in the {@link KeyRangeLookupTree}. Holds information
pertaining to a single index file, viz file
* name, min record key and max record key.
*/
+@Getter
class KeyRangeNode implements Comparable<KeyRangeNode>, Serializable {
private final List<String> fileNameList = new ArrayList<>();
private final String minRecordKey;
private final String maxRecordKey;
+ @Setter
private String rightSubTreeMax = null;
+ @Setter
private String leftSubTreeMax = null;
+ @Setter
private String rightSubTreeMin = null;
+ @Setter
private String leftSubTreeMin = null;
+ @Setter
private KeyRangeNode left = null;
+ @Setter
Review Comment:
Oh, cool, TIL that `@Setter ignores private finals` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
