voonhous commented on code in PR #17524:
URL: https://github.com/apache/hudi/pull/17524#discussion_r2600982937
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/WriteStatus.java:
##########
@@ -49,32 +50,48 @@
* Status of a write operation.
*/
@PublicAPIClass(maturity = ApiMaturityLevel.STABLE)
+@Slf4j
public class WriteStatus implements Serializable {
-
- private static final Logger LOG = LoggerFactory.getLogger(WriteStatus.class);
private static final long serialVersionUID = 1L;
private static final long RANDOM_SEED = 9038412832L;
+ @Getter
Review Comment:
We can, was performing a 1:1 swap as the original code did not have getters
for:
```
trackSuccessRecords
random
```
Question here is, while we want to improve readability, are we also looking
for a 1:1 swap?
The former may introduce getters that we are not currently using.
That being said, in the initial code, we do have some orphaned getters which
we were not exactly using, i.e. usages were removed, but getters were never
removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
