voonhous commented on code in PR #17536:
URL: https://github.com/apache/hudi/pull/17536#discussion_r2609013264
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/util/OrderingValueEngineTypeConverter.java:
##########
@@ -46,16 +48,16 @@ public Comparable convert(Comparable value) {
: this.converters.get(0).apply(value);
}
- public static List<Function<Comparable, Comparable>> createConverters(Schema
dataSchema, List<String> orderingFieldNames, boolean utcTimezone) {
+ public static List<Function<Comparable, Comparable>>
createConverters(HoodieSchema dataSchema, List<String> orderingFieldNames,
boolean utcTimezone) {
if (orderingFieldNames.isEmpty()) {
return Collections.singletonList(Function.identity());
}
return orderingFieldNames.stream().map(f -> {
- Option<Schema> fieldSchemaOpt =
AvroSchemaUtils.findNestedFieldSchema(dataSchema, f, true);
+ Option<HoodieSchema> fieldSchemaOpt =
HoodieSchemaUtils.getNestedField(dataSchema,
f).map(Pair::getValue).map(HoodieSchemaField::getNonNullSchema);
Review Comment:
Ignore, since we've reached consensus on not porting over these methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
