yihua commented on code in PR #17536:
URL: https://github.com/apache/hudi/pull/17536#discussion_r2612553777
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/BaseHoodieLogRecordReader.java:
##########
@@ -215,7 +215,7 @@ private void scanInternalV1(Option<KeySpec> keySpecOpt) {
try {
// Iterate over the paths
logFormatReaderWrapper = new HoodieLogFormatReader(storage, logFiles,
- readerSchema, reverseReader, bufferSize, shouldLookupRecords(),
recordKeyField, internalSchema);
+ readerSchema.toAvroSchema(), reverseReader, bufferSize,
shouldLookupRecords(), recordKeyField, internalSchema);
Review Comment:
Should log reader also take `HoodieSchema`? Is the related refactoring
separated to another PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
