the-other-tim-brown commented on code in PR #17536:
URL: https://github.com/apache/hudi/pull/17536#discussion_r2612382674
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/SecondaryIndexRecordGenerationUtils.java:
##########
@@ -342,15 +342,15 @@ public Pair<String, String> next() {
};
}
- private static Schema
getRequestedSchemaForSecondaryIndex(HoodieTableMetaClient metaClient,
HoodieSchema tableSchema, String secondaryKeyField) {
+ private static HoodieSchema
getRequestedSchemaForSecondaryIndex(HoodieTableMetaClient metaClient,
HoodieSchema tableSchema, String secondaryKeyField) {
String[] recordKeyFields;
- if (tableSchema.getField(RECORD_KEY_METADATA_FIELD) != null) {
+ if (tableSchema.getField(RECORD_KEY_METADATA_FIELD).isPresent()) {
Review Comment:
I found this by doing that inspection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
