yihua commented on code in PR #17536:
URL: https://github.com/apache/hudi/pull/17536#discussion_r2612549302
##########
hudi-common/src/main/java/org/apache/hudi/common/table/PartitionPathParser.java:
##########
@@ -103,11 +102,9 @@ static Object parseValue(String partitionValue, Schema
fieldSchema) {
return Boolean.parseBoolean(partitionValue);
case BYTES:
case FIXED:
- if (fieldSchema.getLogicalType() instanceof LogicalTypes.Decimal) {
- return new java.math.BigDecimal(partitionValue);
- } else {
- return partitionValue.getBytes(StandardCharsets.UTF_8);
- }
+ return partitionValue.getBytes(StandardCharsets.UTF_8);
+ case DECIMAL:
+ return new BigDecimal(partitionValue);
Review Comment:
Should time-based types also be considered here?
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieRecordMerger.java:
##########
@@ -24,13 +24,12 @@
import org.apache.hudi.common.config.TypedProperties;
import org.apache.hudi.common.engine.RecordContext;
import org.apache.hudi.common.model.HoodieRecord.HoodieRecordType;
+import org.apache.hudi.common.schema.HoodieSchema;
import org.apache.hudi.common.table.HoodieTableConfig;
import org.apache.hudi.common.table.HoodieTableVersion;
import org.apache.hudi.common.table.read.BufferedRecord;
import org.apache.hudi.common.util.Option;
-import org.apache.avro.Schema;
Review Comment:
Curious to see how many classes still import `org.apache.avro.Schema` after
quite a few refactoring PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
