voonhous commented on code in PR #19410:
URL: https://github.com/apache/hudi/pull/19410#discussion_r3679991440
##########
.github/workflows/bot.yml:
##########
@@ -87,8 +87,11 @@ jobs:
#
# Stage the copy outside the workspace. `mvn apache-rat:check` in the
RAT check step scans
# the filesystem from the repository root, so a copy of the tree left
inside the workspace
- # gets scanned too, and every root-anchored exclude in the root pom
(such as
- # `hudi-trino-plugin/**`) silently stops applying to it.
+ # gets scanned too, and every root-anchored exclude in the root pom
(such as `.github/**`)
+ # silently stops applying to it.
+ #
+ # hudi-trino needs no RAT exclude: its files carry AL headers that RAT
accepts, and its
+ # Trino-style license checks are handled by airlift.
Review Comment:
Follow-up: filed #19412 (child of #18780) to align `hudi-trino` with Hudi
conventions -- ASF headers + Hudi checkstyle enforcement -- after this
release-staging work lands. Package stays `io.trino.plugin.hudi.*` per the
RFC-105 shim contract, so RAT and the repo-standard checks become the single
source of truth here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
