wombatu-kun commented on code in PR #19410:
URL: https://github.com/apache/hudi/pull/19410#discussion_r3680237308
##########
.github/workflows/bot.yml:
##########
@@ -87,8 +87,11 @@ jobs:
#
# Stage the copy outside the workspace. `mvn apache-rat:check` in the
RAT check step scans
# the filesystem from the repository root, so a copy of the tree left
inside the workspace
- # gets scanned too, and every root-anchored exclude in the root pom
(such as
- # `hudi-trino-plugin/**`) silently stops applying to it.
+ # gets scanned too, and every root-anchored exclude in the root pom
(such as `.github/**`)
+ # silently stops applying to it.
+ #
+ # hudi-trino needs no RAT exclude: its files carry AL headers that RAT
accepts, and its
+ # Trino-style license checks are handled by airlift.
Review Comment:
`validate_source_copyright.sh` still prunes `hudi-trino` from its ASF-header
grep on the same airlift rationale, and it cannot simply be dropped since the
module's files carry the short AL header rather than the `Licensed to the
Apache Software Foundation (ASF)` wording that script matches. Is that prune
part of #19412?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
