vax-r commented on code in PR #1803: URL: https://github.com/apache/iggy/pull/1803#discussion_r2106073945
########## core/common/src/types/configuration/http_config/http_connection_string_options.rs: ########## @@ -0,0 +1,133 @@ +/* Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +use crate::{ConnectionStringOptions, IggyDuration, IggyError}; +use std::str::FromStr; + +#[derive(Debug)] +pub struct HttpConnectionStringOptions { + tls_enabled: bool, + tls_domain: String, + tls_ca_file: Option<String>, + heartbeat_interval: IggyDuration, + retries: u32, +} + +impl HttpConnectionStringOptions { + pub fn retries(&self) -> u32 { + self.retries + } +} + +impl ConnectionStringOptions for HttpConnectionStringOptions { + fn tls_enabled(&self) -> bool { Review Comment: `retries` doesn't exists for QUIC now, I suppose we can add the method in `ConnectionStringOptions` and make `QuicConnectionString` to have `retries` but not actually working for now, or we should neglect this field now and add it in `ConnectionStringOptions` after `retries` is enabled in QUIC ? I think the former one will be better, given other protocol to know the expected common fields to have. What do you think ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
