vax-r commented on PR #1803: URL: https://github.com/apache/iggy/pull/1803#issuecomment-2918255716
> Looks good! There's one thing left - please take a look at `IggyClient` and `IggyClientBuilder` which have `from_connection_string()`. This function is tied to `TcpClient`, while it should now use the particular transport instead. > > I guess that it could be easily implemented with the already existing `ConnectionStringUtils::parse_protocol()`, via pattern matching. Thanks for the reminder ! I've extend the implementation of both methods and add corresponding unit test. Please take a look while you're available, thanks ! Btw, I don't think we can validate config options from `IggyClient` since `client` field of it is a `dyn Client` . We can't make assumption that every `client` Implementing `Client` trait has a field `config`, so I didn't validate config options in the unit test of `IggyClient` and `IggyClientBuilder`. If there's any possible way of doing so, please let me know and I'll fix it up, thanks ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
