vax-r commented on PR #1803:
URL: https://github.com/apache/iggy/pull/1803#issuecomment-2908209291
> It looks like some of the previous tests for connection strings were
removed (maybe by a mistake, when restructuring to the monorepo). Here's how it
looked before:
>
> ```rust
> #[cfg(test)]
> mod tests {
> use super::*;
>
> #[test]
> fn connection_string_without_username_should_fail() {
> let server_address = "localhost:1234";
> let value =
format!("{CONNECTION_STRING_PREFIX}:secret@{server_address}");
> let connection_string: Result<ConnectionString, IggyError> =
ConnectionString::new(&value);
> assert!(connection_string.is_err());
> }
> ```
Cuz I see the test here are against `ConnectionString::new()` , which
doesn't call `parse_protocol()` first ( it shouldn't ofc, from this layer ) .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
