spetz commented on PR #1803: URL: https://github.com/apache/iggy/pull/1803#issuecomment-2917036593
Looks good! There's one thing left - please take a look at `IggyClient` and `IggyClientBuilder` which have `from_connection_string()`. This function is tied to `TcpClient`, while it should now use the particular transport instead. I guess that it could be easily implemented with the already existing `ConnectionStringUtils::parse_protocol()`, via pattern matching. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
