hubcio commented on PR #3517: URL: https://github.com/apache/iggy/pull/3517#issuecomment-4776484351
tbh i'm not a fan of this PR, parsing kernel version seems sketchy and doesn't feel right. (convince me that i'm from if you disagree 🦀) what if someone has custom kernel >= 6.18 which doesn't have iouring support? i would recommend contribution to crate `io-uring`, and extending API `is_feature_*` (+ adding dep of this crate to iggy, which we implicitly already have due to being dependant on `compio`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
