mfyuce commented on PR #3517: URL: https://github.com/apache/iggy/pull/3517#issuecomment-4791175680
All five points addressed in this push: **macOS boot crash** -- `check_kernel_version` is now gated behind `#[cfg(target_os = "linux")]`; the function body is wrapped in a `#[cfg(target_os = "linux")]` block and falls through to `Ok(())` on every other platform. macOS arm64 no longer hits the missing `/proc` path. **Wrong kernel const** -- `MIN_KERNEL_MAJOR/MINOR` corrected from `6.8` to `5.19` to match `diagnostics.rs` and the actual kernel landing of `IORING_SETUP_COOP_TASKRUN` + `IORING_SETUP_TASKRUN_FLAG`. The `6.8` value was our production kernel, not the real floor. **Unused variable on macOS** -- parameter renamed to `_keep_worker_pool`; the `_` prefix suppresses the `unused_variables` warning on macos aarch64 where the cfg block is compiled out, while the value remains accessible on Linux. **Undocumented invariant** -- docstring on `create_shard_executor` now names the concrete paths that must not reach `spawn_blocking` for `_keep_worker_pool = false` to be safe (io_uring fsync/read/write opcodes, no DNS resolution, no `set_permissions`). **Test re-inlines parse logic** -- extracted `parse_kernel_version` and `kernel_meets_min` as pure helpers; tests now exercise these directly with representative inputs (exact boundary, distro suffix, malformed). `check_kernel_version_matches_host` calls the real function and only asserts on Linux hosts that meet the 5.19 minimum. /ready -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
