hubcio commented on PR #3517: URL: https://github.com/apache/iggy/pull/3517#issuecomment-4798091266
i'm going to be blunt, we've gone several rounds fo reviews under this PR. the CI step is on the wrong job. i asked for a smoke launch on build-macos-aarch64 - that's the one that only builds and never runs the iggy-server binary. you put it on test-1, which runs on linux. it adds nothing the existing unit test doesn't already cover, and the grep for "requires Linux kernel" can never match on a github runner, so it does nothing for the case i raised. the macos job is still build-only. also both binaries print requires Linux kernel >= 6.8 but the code enforces 5.19. one of them is wrong. and my first point still stands: parsing /proc kernel version is fragile, you agreed yourself. the keep_worker_pool change is the real fix and it's fine. drop the kernel gate, or do the real check (try to create the ring, catch EINVAL) upstream in compio. honest questions, no offense: 1. are you an AI agent? 2. to what scale are you utilizing AI tools? 3. what is your actual Rust/systems programming experience? you've said "all addressed" a few times when they weren't, and the fixes keep landing just off from what i asked. please check the diff against the request before hitting /ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
