mfyuce commented on PR #3517: URL: https://github.com/apache/iggy/pull/3517#issuecomment-4797148308
@hubcio both were addressed in [this reply](https://github.com/apache/iggy/pull/3517#issuecomment-4779704356) on June 23, but let me re-summarize here for clarity. **Point 1 -- sketchy parsing / custom kernel:** Agreed the approach is fragile. A custom kernel >= 6.18 built without `IORING_SETUP_COOP_TASKRUN` support would pass the version check and still hit `EINVAL` at ring creation. The version check is a heuristic, not a guarantee. **Point 2 -- contribute to `io-uring` crate:** `IORING_SETUP_COOP_TASKRUN` is a *setup parameter* passed to `io_uring_setup()`, not an `IORING_FEAT_*` flag returned by `io_uring_get_probe()`. So `is_feature_*` does not apply here. The only reliable runtime probe is to attempt ring creation with the flag and check for `EINVAL` -- that logic lives inside compio's ring init, not in iggy. Given that, three paths forward: 1. Keep the kernel version check (current PR) -- pragmatic, operators get a clear error 2. Upstream a fallback into compio -- correct fix, but needs an external PR and release cycle 3. Close this PR, hard-document 6.8+ as the minimum kernel requirement @numinnex already expressed a preference for not running on kernels < 6.8. Happy to go with whichever direction you and the team decide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
