jiengup commented on code in PR #3656:
URL: https://github.com/apache/iggy/pull/3656#discussion_r3572256451
##########
.devcontainer/devcontainer.json:
##########
@@ -0,0 +1,66 @@
+{
+ "name": "Apache Iggy",
+ "hostRequirements": {
+ "cpus": 4,
+ "memory": "16gb",
+ "storage": "32gb"
+ },
+ "build": {
+ "dockerfile": "Dockerfile",
+ "context": "..",
+ "args": {
+ "RUST_VERSION": "1.96"
+ }
+ },
+ "features": {},
Review Comment:
I haven't run any UTs in either GitHub Codespace or local devcontainer.
Cause GitHub Codespaces run on the Azure VM, which has incomplete io-uring
support.
That's to say, `cargo run --bin iggy-server --
--with-default-root-credentials --fresh` will panic soon after it's running,
reporting `thread 'shard-0' (82422) panicked at
/usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/compio-driver-0.12.3/src/asyncify.rs:118:25:
the thread pool is needed but no worker thread is running`
I guess it's because some opcodes are fallbacked to the blocking thread
pool. Because QUIC server can start successfully while TCP/HTTP/WebSocket
report the same issue above.
I'm not familiar with iggy test infrastracture and I don't know if it can
run without a server running. So at first this PR is intent to support
rust-analyzer for simple code review or editing in PR turns .
BTW, I want to propose adding a `IGGY_THREAD_POOL_LIMIT' env to replace the
constant `0` when initializing the iggy per-thread shard. Then maybe some
senarios can be realized.
Any ideas or suggestions about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
