hubcio commented on code in PR #3656:
URL: https://github.com/apache/iggy/pull/3656#discussion_r3577427147
##########
.devcontainer/devcontainer.json:
##########
@@ -0,0 +1,66 @@
+{
+ "name": "Apache Iggy",
+ "hostRequirements": {
+ "cpus": 4,
+ "memory": "16gb",
+ "storage": "32gb"
+ },
+ "build": {
+ "dockerfile": "Dockerfile",
+ "context": "..",
+ "args": {
+ "RUST_VERSION": "1.96"
+ }
+ },
+ "features": {},
Review Comment:
to be honest, I intentionally disabled ability to run iggy with thread pool
on linux. we advise ourselves as io-uring software, so I'd rather not support
half-baked thread pool options - some people might run iggy on box which doesnt
have ioruing, so it'll automatically switch to thread pool and they'll complain
about performance and ditch iggy because of that.
that being said, maybe I could settle for a workaround: enable thread pool
only for debug mode, and only if io uring is not supported.
does that make sense? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
