slbotbm commented on code in PR #3656:
URL: https://github.com/apache/iggy/pull/3656#discussion_r3615853176
##########
.devcontainer/devcontainer.json:
##########
Review Comment:
Docker-based tests with bind mounts will fail. The workspace is mounted at
/workspaces/iggy, but Docker commands use the host daemon through
docker-outside-of-docker. Host Docker cannot resolve container-only paths used
by BDD Compose volumes or testcontainers.
##########
.devcontainer/devcontainer.json:
##########
@@ -0,0 +1,67 @@
+{
+ "name": "Apache Iggy",
+ "hostRequirements": {
+ "cpus": 4,
+ "memory": "16gb",
+ "storage": "32gb"
+ },
+ "build": {
+ "dockerfile": "Dockerfile",
+ "context": ".."
+ },
+ "features": {
+ "ghcr.io/devcontainers/features/docker-outside-of-docker:1": {
+ "moby": false
+ }
+ },
+ "remoteUser": "vscode",
+ "workspaceMount":
"source=${localWorkspaceFolder},target=/workspaces/iggy,type=bind,consistency=cached",
+ "workspaceFolder": "/workspaces/iggy",
+ "runArgs": [
+ "--init",
+ "--security-opt", "seccomp=unconfined",
+ "--ulimit", "memlock=-1:-1",
+ "--cap-add=SYS_NICE"
+ ],
+ "mounts": [
+ "type=volume,source=iggy-cargo-registry,target=/usr/local/cargo/registry",
+ "type=volume,source=iggy-target,target=/workspaces/iggy/target"
+ ],
+ "containerEnv": {
+ "CARGO_BUILD_JOBS": "4",
+ "IGGY_HTTP_ADDRESS": "0.0.0.0:3000",
+ "IGGY_QUIC_ADDRESS": "0.0.0.0:8080",
Review Comment:
Iggy's QUIC endpoint uses UDP transport, not TCP. This setting will make the
QUIC client time-out.
fix: Publish UDP explicitly when creating the development container.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
