jiengup commented on code in PR #3656:
URL: https://github.com/apache/iggy/pull/3656#discussion_r3586796086
##########
.devcontainer/devcontainer.json:
##########
@@ -0,0 +1,66 @@
+{
+ "name": "Apache Iggy",
+ "hostRequirements": {
+ "cpus": 4,
+ "memory": "16gb",
+ "storage": "32gb"
+ },
+ "build": {
+ "dockerfile": "Dockerfile",
+ "context": "..",
+ "args": {
+ "RUST_VERSION": "1.96"
+ }
+ },
+ "features": {},
Review Comment:
Totally agree, I don't mean to fully support configurable thread num. We can
add a debug-face env variable for some special scenarios, such as Github
Codespace.
I've added the `docker-outside-of-docker` feature in the latest commit and
passed several docker-based integration UTs in Github Codespace after changing
`proactor.thread_pool_limit(0)` to `proactor.thread_pool_limit(5)`. The
compilation is very slow, and the storage is limited for a large number of UT
binaries. But we can finally support a quick runtime for our codebase. :)
If you think making the thread num configurable for debug is a good idea, I
can open a follow-up issue for it, or you can give any other instructions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
