mfyuce commented on code in PR #3516: URL: https://github.com/apache/iggy/pull/3516#discussion_r3711039662
########## core/connectors/sources/otlp_source/src/lib.rs: ########## @@ -0,0 +1,180 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use async_trait::async_trait; +use iggy_connector_sdk::{ + ConnectorState, Error, ProducedMessage, ProducedMessages, Schema, Source, source_connector, +}; +use serde::{Deserialize, Serialize}; +use tokio::sync::{Mutex, mpsc, oneshot}; +use tokio::task::JoinHandle; +use tonic::transport::server::TcpIncoming; +use tracing::info; + +pub(crate) mod convert; +pub(crate) mod server; + +source_connector!(OtlpSource); + +/// How messages are stored in the Iggy topic. +/// +/// `Json` (default): each OTLP signal item (span / data-point / log record) +/// is stored as a flat JSON document. Human-readable but verbose. +/// +/// `Proto`: the entire `Export*ServiceRequest` proto is stored as raw bytes +/// per gRPC call. Typically 4-5x smaller than JSON and zero-copy on the sink +/// side when paired with `otlp_sink`'s `format = "proto"`. +#[derive(Debug, Clone, Copy, Default, Serialize, Deserialize)] +#[serde(rename_all = "lowercase")] +pub enum StorageFormat { + #[default] + Json, + Proto, +} + +#[derive(Debug)] +pub struct OtlpSource { + id: u32, + config: OtlpSourceConfig, + rx: Mutex<Option<mpsc::Receiver<ProducedMessage>>>, + shutdown_tx: Mutex<Option<oneshot::Sender<()>>>, + server_task: Mutex<Option<JoinHandle<()>>>, +} + +#[derive(Debug, Clone, Serialize, Deserialize)] +pub struct OtlpSourceConfig { + pub listen_addr: String, + #[serde(default = "default_channel_capacity")] + pub channel_capacity: usize, + #[serde(default = "default_batch_size")] + pub batch_size: usize, + #[serde(default)] + pub format: StorageFormat, +} + +fn default_channel_capacity() -> usize { + 50_000 +} + +fn default_batch_size() -> usize { + 1_000 +} + +impl OtlpSource { + pub fn new(id: u32, config: OtlpSourceConfig, _state: Option<ConnectorState>) -> Self { + OtlpSource { + id, + config, + rx: Mutex::new(None), + shutdown_tx: Mutex::new(None), + server_task: Mutex::new(None), + } + } +} + +#[async_trait] +impl Source for OtlpSource { + async fn open(&mut self) -> Result<(), Error> { Review Comment: `open()` now rejects it with `Error::InvalidConfigValue` before the channel is built. Covered by a config test, along with defaults, `format` parsing and unknown-key rejection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
