mfyuce commented on code in PR #3516: URL: https://github.com/apache/iggy/pull/3516#discussion_r3711173973
########## core/connectors/sources/otlp_source/config.toml: ########## @@ -0,0 +1,36 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + Review Comment: Documented in both, with a "Storage format" section in the README covering the tradeoff and a commented entry in `config.toml`. One caveat on the zero-copy claim, since the docs name a crate that is not in the tree yet. The pairing is with `otlp_sink`, tracked in #3529, which the stale bot closed on 2026-07-17 and which I am picking back up. Proto mode is useful on its own, it is the storage saving that does not depend on the sink, but the end-to-end zero-copy path only closes once #3529 lands. Happy to reword the README to describe the sink generically instead of naming the crate if you would rather not reference an unmerged PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
