mfyuce commented on PR #3516: URL: https://github.com/apache/iggy/pull/3516#issuecomment-5177309637
> @mfyuce - few observations. Basic - PR do not describe the issue it closes. It does mention the motivation of the PR. > > Similarly code coverage , tests coverage are not visible. Done, both. The description now follows the template, with `Closes #3815` and the motivation. On coverage: the connector had no tests, this adds 29. They cover the OTLP to JSON conversion for all three signals (log records, spans, and every metric data point type), the `partial_success` record accounting in both storage formats including the encode-failure path, and config deserialization with defaults, `format` parsing and unknown-key rejection. All of it is pure functions with no I/O, so the suite runs in under a second and adds nothing measurable to CI time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
