hubcio commented on code in PR #4017:
URL: https://github.com/apache/iggy/pull/4017#discussion_r3957559523
##########
foreign/python/src/client.rs:
##########
@@ -704,7 +681,8 @@ impl IggyClient {
/// Args:
/// stream: Stream identifier as `str | int`.
/// name: Topic name as `str`.
- /// partitions_count: Number of partitions as `int`.
+ /// partitions_count: Number of partitions as `int`, between 1 and 1000
Review Comment:
nit: `create_topic` accepts zero partitions - admission only rejects counts
above 1000, and the HTTP validator allows 0 too. say "at most 1000" here and
regenerate the stub.
##########
core/shard/src/lib.rs:
##########
@@ -2530,6 +2530,10 @@ where
self.metrics.record_partition_removed();
confirmed_remove = true;
if let Some(partition) = removed {
+ // The tombstone fences writes before this point.
Rolling the
+ // detached counters out here prevents late shard
activity from
+ // underflowing or leaking into the topic and stream
totals.
+ partition.stats.zero_out_all();
Review Comment:
warning: #4046 landed on master with this same `zero_out_all()` call a few
lines below, so after merge it runs twice. drop this hunk and the roll-out
claim in the PR body; the simulator assertions still hold on the master call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
